Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cluster): vargroup "latest" doesn't work #135

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix(cluster): vargroup "latest" doesn't work #135

merged 1 commit into from
Oct 11, 2024

Conversation

fubuloubu
Copy link
Member

@fubuloubu fubuloubu commented Oct 11, 2024 •
edited
Loading

What I did

$ silverback cluster bots new -g <some vargroup> ...
...                                                                                                                              
  File "site-packages/silverback/_cli.py", line 859, in new_bot                                                      
    environment = [cluster.variable_groups[vg_name].get_revision("latest") for vg_name in vargroups]                                                                              
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                        
  File "site-packages/silverback/cluster/client.py", line 118, in get_revision                                       
    handle_error_with_response(response)                                                                                                                                          
  File "site-packages/silverback/cluster/client.py", line 54, in handle_error_with_response                          
    raise RuntimeError(message)                                                                                                                                                   
RuntimeError: Not Found

How I did it

How to verify it

I tested locally w/ staging cluster

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
    - [ ] New test cases have been added and are passing
    - [ ] Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@fubuloubu fubuloubu enabled auto-merge (squash) October 11, 2024 22:42
@fubuloubu fubuloubu merged commit 0c24de0 into main Oct 11, 2024
25 checks passed
@fubuloubu fubuloubu deleted the fix/cluster/vargroup-latest branch October 11, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnson2427 johnson2427 johnson2427 approved these changes

@mikeshultz mikeshultz Awaiting requested review from mikeshultz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fubuloubu @johnson2427